test: update visual tests to use fixed browser window height #8405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's 1px difference in SauceLabs (apparently there's some rounding involved). I'll close the PR for now. |
web-padawan
force-pushed
the
test/visual-tests-window-height
branch
from
70ebbba to
530a2d7
Compare
|
UPD: looks like we need to call |
vursen
approved these changes
Dec 30, 2024
web-padawan
force-pushed
the
test/visual-tests-window-height
branch
from
4eb52bb to
124b7f5
Compare
|
Updated screenshots for all components that use the document body (dialog, overlay, login, notification etc). |
|
vursen
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a custom WTR command to emulate missing
setViewport()(adding that requires upgrading WebdriverIO to the new major version and I couldn't get it done quickly) and to avoid changing screenshot size when bumping Chrome version.Type of change